[all-commits] [llvm/llvm-project] d26a8d: [AIX] Make sure we use export lists for plugins

David Tenty via All-commits all-commits at lists.llvm.org
Fri May 8 11:00:43 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d26a8daa491ce56ef719708f2dbefb519c4c2f3e
      https://github.com/llvm/llvm-project/commit/d26a8daa491ce56ef719708f2dbefb519c4c2f3e
  Author: David Tenty <daltenty at ibm.com>
  Date:   2020-05-08 (Fri, 08 May 2020)

  Changed paths:
    M llvm/CMakeLists.txt
    M llvm/cmake/modules/AddLLVM.cmake
    M llvm/cmake/modules/HandleLLVMOptions.cmake
    M llvm/utils/extract_symbols.py

  Log Message:
  -----------
  [AIX] Make sure we use export lists for plugins

Summary:
Besides just generating and consuming the lists, this includes:

 * Calling  nm with the right options in extract_symbols.py. Such as not
  demangling C++ names, which AIX nm does by default, and accepting both
  32/64-bit names.
 * Not having nm sort the list of symbols or we may run in to memory
   issues on debug builds, as nm calls a 32-bit sort.
 * Defaulting to having LLVM_EXPORT_SYMBOLS_FOR_PLUGINS on for AIX
 * CMake versions prior to 3.16 set the -brtl linker flag globally on
   AIX. Clear it out early on so we don't run into failures. We will set
   it as needed.

Reviewers: jasonliu, DiggerLin, stevewan, hubert.reinterpretcast

Reviewed By: hubert.reinterpretcast

Subscribers: hubert.reinterpretcast, mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70972




More information about the All-commits mailing list