[all-commits] [llvm/llvm-project] 52712d: Re-land "get rid of PythonInteger::GetInteger()"

lawrence-danna-apple via All-commits all-commits at lists.llvm.org
Fri May 8 10:58:24 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 52712d3ff7a2f7bcf737996d6ab59ef2cc29c20d
      https://github.com/llvm/llvm-project/commit/52712d3ff7a2f7bcf737996d6ab59ef2cc29c20d
  Author: Lawrence D'Anna <lawrence_danna at apple.com>
  Date:   2020-05-08 (Fri, 08 May 2020)

  Changed paths:
    M lldb/bindings/python/python-typemaps.swig
    M lldb/bindings/python/python-wrapper.swig
    M lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
    M lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp

  Log Message:
  -----------
  Re-land "get rid of PythonInteger::GetInteger()"

This was reverted due to a python2-specific bug.  Re-landing with a fix
for python2.

Summary:
One small step in my long running quest to improve python exception handling in
LLDB.  Replace GetInteger() which just returns an int with As<long long> and
friends, which return Expected types that can track python exceptions

Reviewers: labath, jasonmolenda, JDevlieghere, vadimcn, omjavaid

Reviewed By: labath, omjavaid

Subscribers: omjavaid, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D78462




More information about the All-commits mailing list