[all-commits] [llvm/llvm-project] b14c37: [lldb/Platform] Return a std::string from GetSDKPath

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b14c37a29a5455853419f5fe0605f6023c51de89
      https://github.com/llvm/llvm-project/commit/b14c37a29a5455853419f5fe0605f6023c51de89
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-28 (Tue, 28 Apr 2020)

  Changed paths:
    M lldb/include/lldb/Target/Platform.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h

  Log Message:
  -----------
  [lldb/Platform] Return a std::string from GetSDKPath

Nothing guarantees that the objects in the StringMap remains at the same
address when the StringMap grows. Therefore we shouldn't return a
reference into the StringMap but return a copy of the string instead.


  Commit: 75c3d6f49c450a8b522a6731c317e75b73a2f5a3
      https://github.com/llvm/llvm-project/commit/75c3d6f49c450a8b522a6731c317e75b73a2f5a3
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-28 (Tue, 28 Apr 2020)

  Changed paths:
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h

  Log Message:
  -----------
  [lldb/Platform] Synchronize access to SDK String Map.

The SwiftASTContext queries this function in parallel and requires
synchronization.


  Commit: 6e693386afedab5237b42679d94ca6c72684621d
      https://github.com/llvm/llvm-project/commit/6e693386afedab5237b42679d94ca6c72684621d
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-28 (Tue, 28 Apr 2020)

  Changed paths:
    M lldb/source/Host/common/Host.cpp

  Log Message:
  -----------
  [lldb/Host] Pass a StringRef to the FileSpec ctor

The FileSpec constructor takes a StringRef so there's no point in going
through a C string.


Compare: https://github.com/llvm/llvm-project/compare/329ebb85a90e...6e693386afed