[all-commits] [llvm/llvm-project] b424b0: [lldb/Target] Avoid race between Communication::Di...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b424b0bf731d1fb338180553a86f912746f640ad
      https://github.com/llvm/llvm-project/commit/b424b0bf731d1fb338180553a86f912746f640ad
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-22 (Wed, 22 Apr 2020)

  Changed paths:
    M lldb/source/Target/Process.cpp

  Log Message:
  -----------
  [lldb/Target] Avoid race between Communication::Disconnect calls.

Avoid a race between the Disconnect call in `Communication::ReadThread`
and the one in `Process::ShouldBroadcastEvent` by reordering the calls
to Disconnect and StopReadThread in `Process::ShouldBroadcastEvent`.

In D77295 Pavel suggested that that might explain the broken pipe I was
seeing. Indeed, changing the order resolved the issue.