[all-commits] [llvm/llvm-project] 5eb8d4: [libc++] Use proper shell escaping in the executors

Louis Dionne via All-commits all-commits at lists.llvm.org
Sat Apr 18 08:23:04 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5eb8d45ab5b85cb3a2edfe995cbf1d4b1beae462
      https://github.com/llvm/llvm-project/commit/5eb8d45ab5b85cb3a2edfe995cbf1d4b1beae462
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-04-18 (Sat, 18 Apr 2020)

  Changed paths:
    A libcxx/test/libcxx/selftest/newformat/remote-substitutions.sh.cpp
    R libcxx/test/libcxx/selftest/newformat/sh.cpp/remote-substitutions.sh.cpp
    A libcxx/test/libcxx/selftest/newformat/shell-escape.sh.cpp
    M libcxx/utils/run.py
    M libcxx/utils/ssh.py

  Log Message:
  -----------
  [libc++] Use proper shell escaping in the executors

This was originally committed as f8452ddfcc33 and reverted in 7cb1aa9d9368.
The issue was that shell builtins were being escaped too, and apparently
Bash won't execute a builtin when it is quoted e.g. '!'. Instead, it
thinks it's a command and it can't find it.

Re-committing the change with that issue fixed.




More information about the All-commits mailing list