[all-commits] [llvm/llvm-project] 87383e: [ELF][ARM] Increase default max-page-size from 409...

Tobias Hieta via All-commits all-commits at lists.llvm.org
Sat Apr 18 08:20:29 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 87383e408d41623ada41e2bbc371b037fa29e894
      https://github.com/llvm/llvm-project/commit/87383e408d41623ada41e2bbc371b037fa29e894
  Author: Tobias Hieta <tobias at hieta.se>
  Date:   2020-04-18 (Sat, 18 Apr 2020)

  Changed paths:
    M lld/ELF/Arch/ARM.cpp
    M lld/test/ELF/Inputs/far-arm-abs.s
    M lld/test/ELF/Inputs/far-long-arm-abs.s
    M lld/test/ELF/arm-abs32-dyn.s
    M lld/test/ELF/arm-adr.s
    M lld/test/ELF/arm-bl-v6.s
    M lld/test/ELF/arm-branch-rangethunk.s
    M lld/test/ELF/arm-branch-undef-weak-plt-thunk.s
    M lld/test/ELF/arm-branch.s
    M lld/test/ELF/arm-copy.s
    M lld/test/ELF/arm-execute-only.s
    M lld/test/ELF/arm-exidx-add-missing.s
    M lld/test/ELF/arm-exidx-canunwind.s
    M lld/test/ELF/arm-exidx-dedup.s
    M lld/test/ELF/arm-exidx-emit-relocs.s
    M lld/test/ELF/arm-exidx-gc.s
    M lld/test/ELF/arm-exidx-order.s
    M lld/test/ELF/arm-exidx-shared.s
    M lld/test/ELF/arm-fix-cortex-a8-blx.s
    M lld/test/ELF/arm-fix-cortex-a8-nopatch.s
    M lld/test/ELF/arm-fix-cortex-a8-recognize.s
    M lld/test/ELF/arm-fix-cortex-a8-thunk-align.s
    M lld/test/ELF/arm-fpic-got.s
    M lld/test/ELF/arm-gnu-ifunc-plt.s
    M lld/test/ELF/arm-gnu-ifunc.s
    M lld/test/ELF/arm-got-relative.s
    M lld/test/ELF/arm-gotoff.s
    M lld/test/ELF/arm-icf-exidx.s
    M lld/test/ELF/arm-mov-relocs.s
    M lld/test/ELF/arm-pie-relative.s
    M lld/test/ELF/arm-plt-reloc.s
    M lld/test/ELF/arm-sbrel32.s
    M lld/test/ELF/arm-target1.s
    M lld/test/ELF/arm-target2.s
    M lld/test/ELF/arm-thumb-adr.s
    M lld/test/ELF/arm-thumb-interwork-abs.s
    M lld/test/ELF/arm-thumb-interwork-notfunc.s
    M lld/test/ELF/arm-thumb-interwork-shared.s
    M lld/test/ELF/arm-thumb-interwork-thunk-v5.s
    M lld/test/ELF/arm-thumb-ldrlit.s
    M lld/test/ELF/arm-thumb-no-undefined-thunk.s
    M lld/test/ELF/arm-thumb-plt-range-thunk-os.s
    M lld/test/ELF/arm-thumb-plt-reloc.s
    M lld/test/ELF/arm-thumb-thunk-empty-pass.s
    M lld/test/ELF/arm-thumb-thunk-symbols.s
    M lld/test/ELF/arm-thumb-undefined-weak.s
    M lld/test/ELF/arm-thunk-largesection.s
    M lld/test/ELF/arm-thunk-multipass-plt.s
    M lld/test/ELF/arm-thunk-nosuitable.s
    M lld/test/ELF/arm-thunk-re-add.s
    M lld/test/ELF/arm-tls-gd-nonpreemptible.s
    M lld/test/ELF/arm-tls-gd32.s
    M lld/test/ELF/arm-tls-ie32.s
    M lld/test/ELF/arm-tls-ldm32.s
    M lld/test/ELF/arm-tls-le32.s
    M lld/test/ELF/arm-tls-norelax-gd-ie.s
    M lld/test/ELF/arm-tls-norelax-gd-le.s
    M lld/test/ELF/arm-tls-norelax-ie-le.s
    M lld/test/ELF/arm-tls-norelax-ld-le.s
    M lld/test/ELF/arm-undefined-weak.s
    M lld/test/ELF/global-offset-table-position-arm.s
    M lld/test/ELF/pack-dyn-relocs-arm2.s
    M lld/test/ELF/pack-dyn-relocs.s

  Log Message:
  -----------
  [ELF][ARM] Increase default max-page-size from 4096 to 6536

See http://lists.llvm.org/pipermail/llvm-dev/2020-April/140549.html

For the record, GNU ld changed to 64k max page size in 2014
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=7572ca8989ead4c3425a1500bc241eaaeffa2c89
"[RFC] ld/ARM: Increase maximum page size to 64kB"

Android driver forced 4k page size in AArch64 (D55029) and ARM (D77746).

A binary linked with max-page-size=4096 does not run on a system with a
higher page size configured. There are some systems out there that do
this and it leads to the binary getting `Killed!` by the kernel.

In the non-linker-script cases, when linked with -z noseparate-code
(default), the max-page-size increase should not cause any size
difference. There may be some VMA usage differences, though.

Reviewed By: psmith, MaskRay

Differential Revision: https://reviews.llvm.org/D77330




More information about the All-commits mailing list