[all-commits] [llvm/llvm-project] 62be83: Recommit "[lldb] Fix TestSettings.test_pass_host_e...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 62be83463a3713612bd85cfa45140ef92c130d57
      https://github.com/llvm/llvm-project/commit/62be83463a3713612bd85cfa45140ef92c130d57
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M lldb/source/Host/windows/ProcessLauncherWindows.cpp
    M lldb/test/API/commands/settings/TestSettings.py

  Log Message:
  -----------
  Recommit "[lldb] Fix TestSettings.test_pass_host_env_vars on windows"

This patch was reverted because it introduced a failure in
TestHelloWorld.py. The reason for that was running "ls" shell command
failed as it was evaluated in an environment with an empty path. This
has now been fixed with D77123, which ensures that all shell commands
inherit the host environment, so this patch should be safe to recommit.

The original commit message was:

A defensive check in ProcessLauncherWindows meant that we would never
attempt to launch a process with a completely empty environment -- the
host environment would be used instead. Instead, I make the function add
an extra null wchar_t at the end of an empty environment. The
documentation on this is a bit fuzzy, but it seems to be what is needed
to make windows accept these kinds of environments.

Reviewers: amccarth, friss

Differential Revision: https://reviews.llvm.org/D76835