[all-commits] [llvm/llvm-project] 6b6a77: [lldb][NFC] Always update m_cache_{hits/misses} in...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Tue Mar 24 12:17:55 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6b6a779ca8ce4025ed0a38fbcfcb6c07334ace57
      https://github.com/llvm/llvm-project/commit/6b6a779ca8ce4025ed0a38fbcfcb6c07334ace57
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M lldb/include/lldb/DataFormatters/FormatCache.h
    M lldb/source/DataFormatters/FormatCache.cpp

  Log Message:
  -----------
  [lldb][NFC] Always update m_cache_{hits/misses} in FormatCache

Summary:
These two variables are only incremented under LLDB_CONFIGURATION_DEBUG but their
value is always logged when verbose lldb formatter logging is enabled, which causes that our
cache hit/miss log looks like this in non-Debug builds:

```
Cache hits: 0 - Cache Misses: 0
...
Cache hits: 0 - Cache Misses: 0
...
Cache hits: 0 - Cache Misses: 0
```

This just always increments those two counters independent of build mode.

Reviewers: JDevlieghere

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D76687




More information about the All-commits mailing list