[all-commits] [llvm/llvm-project] aef982: [lldb] Don't dump the frame in SBTarget::EvaluateE...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Tue Mar 24 12:16:24 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: aef982e35acd2a0c4f6064308601658745e78cfc
      https://github.com/llvm/llvm-project/commit/aef982e35acd2a0c4f6064308601658745e78cfc
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M lldb/source/API/SBTarget.cpp

  Log Message:
  -----------
  [lldb] Don't dump the frame in SBTarget::EvaluateExpression in LLDB_CONFIGURATION_DEBUG

Summary:
Dumping the frame using the user-set format could cause that a debug LLDB doesn't behave as a release LLDB,
which could potentially break replaying a reproducer.

Also it's kinda strange that the frame format set by the user is used in the internal log output.

Reviewers: JDevlieghere

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D76685




More information about the All-commits mailing list