[all-commits] [llvm/llvm-project] 07d2cd: [lldb/cmake] Enable more verbose find_package output.

Matt Davis via All-commits all-commits at lists.llvm.org
Fri Feb 21 10:39:09 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 07d2cdae11633139947f105888163adfd5646ce7
      https://github.com/llvm/llvm-project/commit/07d2cdae11633139947f105888163adfd5646ce7
  Author: Matt Davis <nullptr at fb.com>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M lldb/cmake/modules/FindLuaAndSwig.cmake
    M lldb/cmake/modules/FindPythonInterpAndLibs.cmake

  Log Message:
  -----------
  [lldb/cmake] Enable more verbose find_package output.

Summary:
The purpose of this patch is to make identifying missing dependencies clearer to the user.
`find_package` will report if a package is not found, that output, combined with the exiting
status message, is clearer than not having the additional verbosity.

If the SWIG dependency is required {LLDB_ENABLE_PYTHON, LLDB_ENABLE_LUA}
and SWIG is not available, fail the configuration step.  Terminate the
configure early rather than later with a clear error message.

We could possibly modify:
`llvm-project/lldb/cmake/modules/FindPythonInterpAndLibs.cmake`
However, the patch here seems clear in my opinion.

Reviewers: aadsm, hhb, JDevlieghere

Reviewed By: JDevlieghere

Subscribers: labath, jrm, mgorny, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74917




More information about the All-commits mailing list