[all-commits] [llvm/llvm-project] 5f9402: MSVC Buggy version detection: turn pre-processor e...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Thu Jan 30 16:12:14 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5f940220bf9438e95ffa4a627ac1591be1e1ba6e
      https://github.com/llvm/llvm-project/commit/5f940220bf9438e95ffa4a627ac1591be1e1ba6e
  Author: Mehdi Amini <aminim at google.com>
  Date:   2020-01-31 (Fri, 31 Jan 2020)

  Changed paths:
    M llvm/cmake/modules/CheckCompilerVersion.cmake
    M llvm/include/llvm/Support/Compiler.h

  Log Message:
  -----------
  MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

This allows consumer to override in a cleaner way while still prevent
them from hitting bug without knowing they run an unsupported
configuration.

Recommit after fix by Christopher Tetreault to add parens and ${} to
cmake check to work around CMake configure time "unknown arguments
specified" issue

Differential Revision: https://reviews.llvm.org/D73677
Differential Revision: https://reviews.llvm.org/D73751




More information about the All-commits mailing list