[all-commits] [llvm/llvm-project] 45e3f6: Auto-completion bug fix for dot operator
walter erquinigo via All-commits
all-commits at lists.llvm.org
Thu Jan 30 16:09:20 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 45e3f6660cf4503a8f63ce0a22e574f6d0997914
https://github.com/llvm/llvm-project/commit/45e3f6660cf4503a8f63ce0a22e574f6d0997914
Author: Hector Diaz <hdiaz at fb.com>
Date: 2020-01-30 (Thu, 30 Jan 2020)
Changed paths:
M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py
M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/main.cpp
M lldb/tools/lldb-vscode/lldb-vscode.cpp
Log Message:
-----------
Auto-completion bug fix for dot operator
Summary:
There was a bug on LLDB VSCode where there was the following behavior:
//Code
```
struct foo {
int bar:
};
...
foo my_foo = {10};
```
Trying to auto-complete my_foo.b with my_foo.bar resulted instead with my_foo.my_foo.bar
This diff fixes this bug and adds some tests to check correct behavior.
It also fixes the same bug using the arrow operator (->) when user manually requests completions.
TODO: Fix bug where no recommended completions are automatically shown with arrow operator
{F11249959}
{F11249958}
Reviewers: wallace
Reviewed By: wallace
Subscribers: teemperor, labath, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73506
More information about the All-commits
mailing list