[all-commits] [llvm/llvm-project] 0a002f: [Sema] Try 2: Sanity-check alignment requested via...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Fri Jan 24 05:57:10 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0a002f679be4a9d363e6f21b707493c18158930b
      https://github.com/llvm/llvm-project/commit/0a002f679be4a9d363e6f21b707493c18158930b
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-01-24 (Fri, 24 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/test/Sema/builtin-assume-aligned.c

  Log Message:
  -----------
  [Sema] Try 2: Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

Summary:
For `__builtin_assume_aligned()`, we do validate that the alignment
is not greater than `536870912` (D68824), but we don't do that for
`__attribute__((assume_aligned(N)))` attribute.
I suspect we should.

This was initially committed in a4cfb15d15a8a353fe316f2a9fe1c8c6a6740ef1
but reverted in 210f0882c9e5d6f504b8f29e8a5eae884f812e5c due to
suspicious bot failures.

Reviewers: erichkeane, aaron.ballman, hfinkel, rsmith, jdoerfert

Reviewed By: erichkeane

Subscribers: cfe-commits, llvm-commits

Tags: #llvm, #clang

Differential Revision: https://reviews.llvm.org/D72994




More information about the All-commits mailing list