[all-commits] [llvm/llvm-project] 6ab89c: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined ...

[Fangrui Song via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6ab89c3c5df8b679e6ee240a13356309c048fc71
      https://github.com/llvm/llvm-project/commit/6ab89c3c5df8b679e6ee240a13356309c048fc71
  Author: Fangrui Song <maskray at google.com>
  Date:   2020-01-17 (Fri, 17 Jan 2020)

  Changed paths:
    M lld/ELF/Relocations.cpp
    M lld/test/ELF/weak-undef-hidden.s

  Log Message:
  -----------
  [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol

This essentially reverts b841e119d77ed0502e3a2e710f26a899bef28b3c.

Such code construct can be used in the following way:

  // glibc/stdlib/exit.c
  // clang -fuse-ld=lld => succeeded
  // clang -fuse-ld=lld -fpie -pie => relocation R_PLT_PC cannot refer to absolute symbol
  __attribute__((weak, visibility("hidden"))) extern void __call_tls_dtors();
  void __run_exit_handlers() {
    if (__call_tls_dtors)
        __call_tls_dtors();
  }

Since we allow R_PLT_PC in -no-pie mode, it makes sense to allow it in
-pie mode as well.

Reviewed By: pcc

Differential Revision: https://reviews.llvm.org/D72943