[all-commits] [llvm/llvm-project] 94dd09: Revert "Attempt to fix Go syntax error"

[adrian-prantl via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 94dd096f35a2fc61a1fe67e676e342452000141a
      https://github.com/llvm/llvm-project/commit/94dd096f35a2fc61a1fe67e676e342452000141a
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-01-17 (Fri, 17 Jan 2020)

  Changed paths:
    M llvm/bindings/go/llvm/dibuilder.go

  Log Message:
  -----------
  Revert "Attempt to fix Go syntax error"

This reverts commit c0176916a4824812d25a5a22c4ff7c95857b0cd6.


  Commit: c17aee67f1007426fb12f4081183bb8ec5dc3d15
      https://github.com/llvm/llvm-project/commit/c17aee67f1007426fb12f4081183bb8ec5dc3d15
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-01-17 (Fri, 17 Jan 2020)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    R clang/test/CodeGen/debug-info-sysroot.c
    M clang/test/CodeGen/debug-nvptx.c
    M clang/test/Modules/debug-info-moduleimport.m
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M llvm/bindings/go/llvm/dibuilder.go
    M llvm/include/llvm-c/DebugInfo.h
    M llvm/include/llvm/IR/DIBuilder.h
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/MetadataLoader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    M llvm/lib/IR/AsmWriter.cpp
    M llvm/lib/IR/DIBuilder.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/lib/IR/LLVMContextImpl.h
    M llvm/test/Assembler/dicompileunit.ll
    M llvm/test/Assembler/dimodule.ll
    M llvm/test/Bindings/llvm-c/debug_info.ll
    M llvm/test/CodeGen/X86/load-combine-dbg.ll
    M llvm/test/DebugInfo/X86/DIModule.ll
    M llvm/test/DebugInfo/X86/DIModuleContext.ll
    M llvm/test/DebugInfo/X86/clang-module.ll
    R llvm/test/DebugInfo/X86/split-dwarf-sysroot.ll
    M llvm/tools/llvm-c-test/debuginfo.c
    M llvm/unittests/IR/MetadataTest.cpp

  Log Message:
  -----------
  Revert "Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot"

This reverts commit 12e479475a896f664fb721f98c2d6805185ac352.

I accidentally landed this patch with the wrong commit message ...


  Commit: 7b30370e5bcf569fcdc15204d4c592163fd78cb3
      https://github.com/llvm/llvm-project/commit/7b30370e5bcf569fcdc15204d4c592163fd78cb3
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-01-17 (Fri, 17 Jan 2020)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    A clang/test/CodeGen/debug-info-sysroot.c
    M clang/test/CodeGen/debug-nvptx.c
    M clang/test/Modules/debug-info-moduleimport.m
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M llvm/bindings/go/llvm/dibuilder.go
    M llvm/include/llvm-c/DebugInfo.h
    M llvm/include/llvm/IR/DIBuilder.h
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/MetadataLoader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    M llvm/lib/IR/AsmWriter.cpp
    M llvm/lib/IR/DIBuilder.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/lib/IR/LLVMContextImpl.h
    M llvm/test/Assembler/dicompileunit.ll
    M llvm/test/Assembler/dimodule.ll
    M llvm/test/Bindings/llvm-c/debug_info.ll
    M llvm/test/CodeGen/X86/load-combine-dbg.ll
    M llvm/test/DebugInfo/X86/DIModule.ll
    M llvm/test/DebugInfo/X86/DIModuleContext.ll
    M llvm/test/DebugInfo/X86/clang-module.ll
    A llvm/test/DebugInfo/X86/split-dwarf-sysroot.ll
    M llvm/tools/llvm-c-test/debuginfo.c
    M llvm/unittests/IR/MetadataTest.cpp

  Log Message:
  -----------
  Move the sysroot attribute from DIModule to DICompileUnit

[this re-applies c0176916a4824812d25a5a22c4ff7c95857b0cd6
 with the correct commit message and phabricator link]

This addresses point 1 of PR44213.
https://bugs.llvm.org/show_bug.cgi?id=44213

The DW_AT_LLVM_sysroot attribute is used for Clang module debug info,
to allow LLDB to import a Clang module from source. Currently it is
part of each DW_TAG_module, however, it is the same for all modules in
a compile unit. It is more efficient and less ambiguous to store it
once in the DW_TAG_compile_unit.

This should have no effect on DWARF consumers other than LLDB.

Differential Revision: https://reviews.llvm.org/D71732


Compare: https://github.com/llvm/llvm-project/compare/c0176916a482...7b30370e5bcf