[all-commits] [llvm/llvm-project] be0563: [lldb] Clean up accidentally passing TestDeadStrip.py

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: be05633e28949139093278d5ce57a194756bfb83
      https://github.com/llvm/llvm-project/commit/be05633e28949139093278d5ce57a194756bfb83
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile
    M lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py

  Log Message:
  -----------
  [lldb] Clean up accidentally passing TestDeadStrip.py

This test was accidentally passing on non-darwin OS because it was
explicitly setting the CFLAGS make variable. This meant that (in the
default config) it was building with absolutely no debug info, and so
setting a breakpoint on a stripped symbol failed, because there was
really no trace of it remaining. In other configurations, we were
generating the debug info (-gsplit-dwarf implies -g) and the test failed
because we did not treat the zeroed out debug info address specially.
The test was also xfailed in pretty much every non-standard
configuration.

This patch fixes the makefile to avoid messing with CFLAGS (use
CFLAGS_EXTRAS instead). This causes it to fail in all configurations
(except darwin), and so I replace the various decorators with a simple
os!=darwin check.