[all-commits] [llvm/llvm-project] 898d7a: [clangd] Delete default arguments while moving fun...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 898d7a0695c577b8cfe3b86b974b71f1ecb3e6c2
      https://github.com/llvm/llvm-project/commit/898d7a0695c577b8cfe3b86b974b71f1ecb3e6c2
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
    M clang-tools-extra/clangd/unittests/TweakTests.cpp

  Log Message:
  -----------
  [clangd] Delete default arguments while moving functions out-of-line

Summary:
Only function declarations should have the default arguments.

This patch makes sure we don't propogate those arguments to out-of-line
definitions.

Fixes https://github.com/clangd/clangd/issues/221

Reviewers: hokein

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D71187


  Commit: a209a8000e17ef3560598a44825747aab2f7914d
      https://github.com/llvm/llvm-project/commit/a209a8000e17ef3560598a44825747aab2f7914d
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
    M clang-tools-extra/clangd/unittests/TweakTests.cpp

  Log Message:
  -----------
  [clangd] Delete ctor initializers while moving functions out-of-line

Summary:
Currently we only delete function body from declaration, in addition to
that we should also drop ctor initializers.

Unfortunately CXXConstructorDecl doesn't store the location of `:` before
initializers, therefore we make use of token buffer to figure out where to start
deletion.

Fixes https://github.com/clangd/clangd/issues/220

Reviewers: hokein, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D71188


Compare: https://github.com/llvm/llvm-project/compare/fc3417cb5a9d...a209a8000e17