[all-commits] [llvm/llvm-project] 090809: DWARFDebugLoc(v4): Add an incremental parsing func...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0908093977b2b80d00baa12f0b2f1424dde096fb
      https://github.com/llvm/llvm-project/commit/0908093977b2b80d00baa12f0b2f1424dde096fb
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-11-15 (Fri, 15 Nov 2019)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
    M llvm/test/CodeGen/ARM/debug-info-sreg2.ll
    M llvm/test/DebugInfo/Sparc/subreg.ll
    M llvm/test/DebugInfo/X86/PR26148.ll
    M llvm/test/DebugInfo/X86/debug-loc-offset.mir
    M llvm/test/DebugInfo/X86/dw_op_minus_direct.ll
    M llvm/test/DebugInfo/X86/dwarfdump-debug-loc-error-cases.s
    M llvm/test/DebugInfo/X86/dwarfdump-debug-loc-error-cases2.s
    M llvm/test/DebugInfo/X86/dwarfdump-debug-loc-simple.test
    M llvm/test/DebugInfo/X86/live-debug-variables.ll
    M llvm/test/DebugInfo/X86/pieces-1.ll
    M llvm/test/DebugInfo/X86/sret.ll
    M llvm/test/DebugInfo/X86/stack-value-piece.ll
    M llvm/test/tools/dsymutil/X86/basic-lto-dw4-linking-x86.test
    M llvm/test/tools/dsymutil/X86/basic-lto-linking-x86.test
    M llvm/test/tools/dsymutil/X86/debug-loc-base-addr.test
    M llvm/test/tools/llvm-dwarfdump/X86/debug_loc-OP_addr.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_loc_base_address.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_loc_offset.test
    M llvm/test/tools/llvm-dwarfdump/X86/debugloc.s
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  DWARFDebugLoc(v4): Add an incremental parsing function

Summary:
This adds a visitLocationList function to the DWARF v4 location lists,
similar to what already exists for DWARF v5. It follows the approach
outlined in previous patches (D69672), where the parsed form is always
stored in the DWARF v5 format, which makes it easier for generic code to
be built on top of that. v4 location lists are "upgraded" during
parsing, and then this upgrade is undone while dumping.

Both "inline" and section-based dumping is rewritten to reuse the
existing "generic" location list dumper. This means that the output
format is consistent for all location lists (the only thing one needs to
implement is the function which prints the "raw" form of a location
list), and that debug_loc dumping correctly processes base address
selection entries, etc.

The previous existing debug_loc functionality (e.g.,
parseOneLocationList) is rewritten on top of the new API, but it is not
removed as there is still code which uses them. This will be done in
follow-up patches, after I build the API to access the "interpreted"
location lists in a generic way (as that is what those users really
want).

Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69847