[all-commits] [llvm/llvm-project] 0bab05: [test] Use system locale for mri-utf8.test

[RoboTux via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0bab0538d8cc0de242ed2936a4766930cfc934d2
      https://github.com/llvm/llvm-project/commit/0bab0538d8cc0de242ed2936a4766930cfc934d2
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2019-11-04 (Mon, 04 Nov 2019)

  Changed paths:
    A llvm/test/tools/llvm-ar/mri-nonascii.test
    R llvm/test/tools/llvm-ar/mri-utf8.test

  Log Message:
  -----------
  [test] Use system locale for mri-utf8.test

Summary:
llvm-ar's mri-utf8.test test relies on the en_US.UTF-8 locale to be
installed for its last RUN line to work. If not installed, the unicode
string gets encoded (interpreted) as ascii which fails since the most
significant byte is non zero. This commit changes the test to only rely
on the system being able to encode the pound sign in its default
encoding (e.g. UTF-16 for Microsoft Windows) by always opening the file
via input/output redirection. This avoids forcing a given locale to be
present and supported. A Byte Order Mark is also added to help
recognizing the encoding of the file and its endianness. Finally the
XFAIL on system-darwin is removed since the test actually passes fine on
Mac OS X and XFAIL was only added because it failed before.

Reviewers: gbreynoo, MaskRay, rupprecht, JamesNagurne, jfb

Subscribers: dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68472