[all-commits] [llvm/llvm-project] b7b170: [MachineVerifier] Improve verification of live-in...

Jonas Paulsson via All-commits all-commits at lists.llvm.org
Mon Nov 4 07:23:38 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b7b170c9b46ab4c0a10ecf1d9d5832e70ca992d5
      https://github.com/llvm/llvm-project/commit/b7b170c9b46ab4c0a10ecf1d9d5832e70ca992d5
  Author: Jonas Paulsson <paulsson at linux.vnet.ibm.com>
  Date:   2019-11-04 (Mon, 04 Nov 2019)

  Changed paths:
    M llvm/include/llvm/CodeGen/LivePhysRegs.h
    M llvm/lib/CodeGen/MachineVerifier.cpp
    A llvm/test/MachineVerifier/live-ins-01.mir
    A llvm/test/MachineVerifier/live-ins-02.mir
    A llvm/test/MachineVerifier/live-ins-03.mir

  Log Message:
  -----------
  [MachineVerifier]  Improve verification of live-in lists.

MachineVerifier::visitMachineFunctionAfter() is extended to check the
live-through case for live-in lists. This is only done for registers without
aliases and that are neither allocatable or reserved, such as the SystemZ::CC
register.

The MachineVerifier earlier only catched the case of a live-in use without
an entry in the live-in list (as "using an undefined physical register").

A comment in LivePhysRegs.h has been added stating a guarantee that
addLiveOuts() can be trusted for a full register both before and after
register allocation.

Review: Quentin Colombet
https://reviews.llvm.org/D68267


  Commit: bf6744dfb244dbd2a4abe635f57e45218292743f
      https://github.com/llvm/llvm-project/commit/bf6744dfb244dbd2a4abe635f57e45218292743f
  Author: Jonas Paulsson <paulsson at linux.vnet.ibm.com>
  Date:   2019-11-04 (Mon, 04 Nov 2019)

  Changed paths:
    M llvm/lib/Target/SystemZ/SystemZElimCompare.cpp

  Log Message:
  -----------
  [SystemZ]  Use LivePhysRegs instead of isCCLiveOut() in SystemZElimCompare.cpp

Review: Ulrich Weigand
https://reviews.llvm.org/D68267


Compare: https://github.com/llvm/llvm-project/compare/a0324e911374...bf6744dfb244


More information about the All-commits mailing list