[all-commits] [llvm/llvm-project] 73f255: [TargetLowering] Add getBooleanContents contents c...

topperc via All-commits all-commits at lists.llvm.org
Sun Oct 27 10:26:06 PDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 73f255b83ad77f6d10bc319592f04bbd8461bbcf
      https://github.com/llvm/llvm-project/commit/73f255b83ad77f6d10bc319592f04bbd8461bbcf
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-10-27 (Sun, 27 Oct 2019)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

  Log Message:
  -----------
  [TargetLowering] Add getBooleanContents contents check to "SETCC (SETCC), [0|1], [EQ|NE]  -> SETCC" combine.

This combine is only valid if the inner setcc produces a 0/1 result
or the inner type is MVT::i1.

I haven't seen this cause any issues, just happened to notice it
while reviewing combines in this function.

While there also fix another call to use the value type from the
SDValue for the operand instead of calling SDNode::getValueType(0).
Though its likely the use is result 0, its not guaranteed.




More information about the All-commits mailing list