[all-commits] [llvm/llvm-project] 174967: [nfc][libomptarget] Decrease coupling between files

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Sun Oct 27 07:28:08 PDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 174967f15369fafb0c0bfc13d35963f7890b2c8b
      https://github.com/llvm/llvm-project/commit/174967f15369fafb0c0bfc13d35963f7890b2c8b
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2019-10-27 (Sun, 27 Oct 2019)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/interface.h
    M openmp/libomptarget/deviceRTLs/nvptx/src/cancel.cu
    M openmp/libomptarget/deviceRTLs/nvptx/src/critical.cu
    M openmp/libomptarget/deviceRTLs/nvptx/src/debug.h
    A openmp/libomptarget/deviceRTLs/nvptx/src/device_environment.h
    M openmp/libomptarget/deviceRTLs/nvptx/src/omp_data.cu
    M openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h

  Log Message:
  -----------
  [nfc][libomptarget] Decrease coupling between files

Summary:
[nfc][libomptarget] Decrease coupling between files

debug.h used the symbol omptarget_device_environment so implicitly required
an include of omptarget-nvptx.h to compile. Similarly interface.h uses size_t.

Moving this declaration to a new header means cancel, critical can now build
without omptarget-nvptx.h. After this change, debug.h, cancel.cu, critical.cu
could move under a common source directory.

Reviewers: ABataev, jdoerfert, grokos

Subscribers: openmp-commits

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D69473




More information about the All-commits mailing list