[vmkit-commits] [PATCH] Drop unused ClasspathVM*.inc files, since OpenJDK doesn't have these

Nicolas Geoffray nicolas.geoffray at gmail.com
Tue Oct 25 13:52:43 PDT 2011


OK, so if it makes sense please just do the copy of what you need instead of
copying it all.

In any case, it's kind of "your" directory for now (the OpenJDK directory),
so make it as easy as it can be for you to integrate your changes :)

Nicolas

On Tue, Oct 25, 2011 at 9:31 PM, Will Dietz <wdietz2 at illinois.edu> wrote:

> On Tue, Oct 25, 2011 at 12:35 PM, Nicolas Geoffray
> <nicolas.geoffray at gmail.com> wrote:
> > Ok, I think I get it, but this does not look right to me. Why would
> OpenJDK
> > and Classpath have the same natives?
> >
>
> This patch probably should be included in the previous "copy Classpath
> files to OpenJDK directory" commit, if that helps.
>
> What do you mean re:"natives"?  If you mean that the dynamic
> representation (field layout, etc) of classes is different, and that
> JavaUpcalls is going to have lots of differences, then yes you're
> absolutely correct :).
>
> Doing it this way seemed "cleaner" (this process is teaching me new
> things about that word, heh, sorry) since it was more friendly to
> version control (operations like "copy", etc), as opposed to dropping
> in new code that's 75% copied or whatever.
>
> ~Will
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/vmkit-commits/attachments/20111025/bcb0f0f3/attachment.html>


More information about the vmkit-commits mailing list