[Openmp-dev] Small nit on # endif changes

Peyton, Jonathan L via Openmp-dev openmp-dev at lists.llvm.org
Fri Jun 17 09:24:14 PDT 2016


These set of patches were done for NetBSD compatibility for the OpenMP runtime library, so I assume NetBSD cpp can parse them correctly.
r248209 | joerg | 2015-09-21 15:29:12 -0500 (Mon, 21 Sep 2015) | 2 lines
r248207 | joerg | 2015-09-21 15:21:02 -0500 (Mon, 21 Sep 2015) | 2 lines
r248204 | joerg | 2015-09-21 15:02:45 -0500 (Mon, 21 Sep 2015) | 2 lines
r248203 | joerg | 2015-09-21 14:42:05 -0500 (Mon, 21 Sep 2015) | 2 lines
r248200 | joerg | 2015-09-21 14:40:59 -0500 (Mon, 21 Sep 2015) | 2 lines
r248199 | joerg | 2015-09-21 14:38:56 -0500 (Mon, 21 Sep 2015) | 3 lines
r248198 | joerg | 2015-09-21 14:37:05 -0500 (Mon, 21 Sep 2015) | 3 lines

Internally we've been using the:
#if
...
# define
...
#endif
style, and it is most prominent in kmp_os.h and kmp.h.  I believe the patch was trying to conform to that style.

-- Johnny

-----Original Message-----
From: Openmp-dev [mailto:openmp-dev-bounces at lists.llvm.org] On Behalf Of C Bergström via Openmp-dev
Sent: Friday, June 17, 2016 3:27 AM
To: Hahnfeld, Jonas <Hahnfeld at itc.rwth-aachen.de>
Cc: LLVM-OpenMP (openmp-dev at lists.llvm.org) <openmp-dev at lists.llvm.org>
Subject: Re: [Openmp-dev] Small nit on # endif changes

On Fri, Jun 17, 2016 at 4:17 PM, Hahnfeld, Jonas <Hahnfeld at itc.rwth-aachen.de> wrote:
> I haven’t tested those cpps but I think it's consistent at least in the OpenMP runtime, just have a look into kmp.h...

The patch changed it, so it wasn't fully consistent before.. Why not follow llvm/clang coding styles?

/*
I don't feel strongly about it, but it doesn't help readability */ _______________________________________________
Openmp-dev mailing list
Openmp-dev at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev


More information about the Openmp-dev mailing list