[Openmp-dev] Small nit on # endif changes

Hal Finkel via Openmp-dev openmp-dev at lists.llvm.org
Fri Jun 17 12:49:32 PDT 2016


----- Original Message -----
> From: "C Bergström via Openmp-dev" <openmp-dev at lists.llvm.org>
> To: "Jonas Hahnfeld" <Hahnfeld at itc.rwth-aachen.de>
> Cc: "LLVM-OpenMP (openmp-dev at lists.llvm.org)" <openmp-dev at lists.llvm.org>
> Sent: Friday, June 17, 2016 3:26:41 AM
> Subject: Re: [Openmp-dev] Small nit on # endif changes
> 
> On Fri, Jun 17, 2016 at 4:17 PM, Hahnfeld, Jonas
> <Hahnfeld at itc.rwth-aachen.de> wrote:
> > I haven’t tested those cpps but I think it's consistent at least in
> > the OpenMP runtime, just have a look into kmp.h...
> 
> The patch changed it, so it wasn't fully consistent before.. Why not
> follow llvm/clang coding styles?

Consistency with existing code is an important consideration. In the long term, and for new code, we should be following LLVM's coding conventions. We should have a community conversation about transitioning the existing code base to LLVM's coding conventions.

 -Hal

> 
> /*
> I don't feel strongly about it, but it doesn't help readability
> */
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory


More information about the Openmp-dev mailing list