[Openmp-dev] OpenMP 4 offloading status

C Bergström via Openmp-dev openmp-dev at lists.llvm.org
Thu Jun 16 11:06:20 PDT 2016


On Fri, Jun 17, 2016 at 1:58 AM, Hal Finkel <hfinkel at anl.gov> wrote:
> ----- Original Message -----
>> From: "C Bergström via Openmp-dev" <openmp-dev at lists.llvm.org>
>> To: "Samuel Antão" <samuelfantao at gmail.com>
>> Cc: "LLVM-OpenMP (openmp-dev at lists.llvm.org)" <openmp-dev at lists.llvm.org>
>> Sent: Thursday, June 16, 2016 12:55:01 PM
>> Subject: Re: [Openmp-dev] OpenMP 4 offloading status
>>
>> So it's not lost or forgotten -
>>
>> If the libomptarget is the same thing I'm thinking it is, then it
>> certainly hasn't had all my comments and feedback addressed.
>>
>> 1) The design is not friendly to adding more targets
>> 2) If that offloading is meant to be available to another programming
>> model, it should be abstracted to provide a bit more clean
>> abstraction
>> instead of just zero layer over the OMP API.
>>
>> Lastly and it may be just my opinion, but the way that it's actually
>> coded looks like some 1st year C programmer just got his license to
>> code.
>
> Given that I doubt that's literally true, let's keep the criticism constructive, please. Making comments like this only detracts from your more-constructive points.

So for the record all my comments seem pragmatically ignored. #meh

I gave specific comments on that patch for a handful of the nits.
Regardless of my tone - I'd love to see if it passes clang/llvm coding
standards, clang-tidy or lint..


More information about the Openmp-dev mailing list