[Openmp-dev] OpenMP 4 offloading status

Hal Finkel via Openmp-dev openmp-dev at lists.llvm.org
Thu Jun 16 10:58:09 PDT 2016


----- Original Message -----
> From: "C Bergström via Openmp-dev" <openmp-dev at lists.llvm.org>
> To: "Samuel Antão" <samuelfantao at gmail.com>
> Cc: "LLVM-OpenMP (openmp-dev at lists.llvm.org)" <openmp-dev at lists.llvm.org>
> Sent: Thursday, June 16, 2016 12:55:01 PM
> Subject: Re: [Openmp-dev] OpenMP 4 offloading status
> 
> So it's not lost or forgotten -
> 
> If the libomptarget is the same thing I'm thinking it is, then it
> certainly hasn't had all my comments and feedback addressed.
> 
> 1) The design is not friendly to adding more targets
> 2) If that offloading is meant to be available to another programming
> model, it should be abstracted to provide a bit more clean
> abstraction
> instead of just zero layer over the OMP API.
> 
> Lastly and it may be just my opinion, but the way that it's actually
> coded looks like some 1st year C programmer just got his license to
> code.

Given that I doubt that's literally true, let's keep the criticism constructive, please. Making comments like this only detracts from your more-constructive points.

 -Hal

> I'd be really surprised if this actually passed the clang/llvm
> coding standards..
> 
> On Thu, Jun 16, 2016 at 10:29 PM, Samuel Antão
> <openmp-dev at lists.llvm.org> wrote:
> > Hi Jonas,
> >
> > We are planning to work on a new revision for libomptarget soon.
> > That was
> > delayed because we wanted to add testing that would be enabled by
> > the
> > changes in the driver. Unfortunately, that got delayed too. We are
> > considering create some unit tests that use the libomptarget
> > interface
> > directly so that the progress there can be more independent of what
> > happens
> > in the driver/compiler side.
> >
> > Thanks for your patience,
> > Samuel
> >
> > 2016-06-16 2:26 GMT-04:00 Hahnfeld, Jonas via Openmp-dev
> > <openmp-dev at lists.llvm.org>:
> >>
> >> > -----Original Message-----
> >> > From: Openmp-dev [mailto:openmp-dev-bounces at lists.llvm.org] On
> >> > Behalf
> >> > Of Hal Finkel via Openmp-dev
> >> > Sent: Wednesday, June 15, 2016 7:33 PM
> >> > To: Hervé Yviquel
> >> > Cc: Roel Jordans via Openmp-dev
> >> > Subject: Re: [Openmp-dev] OpenMP 4 offloading status
> >> >
> >> > ----- Original Message -----
> >> > > From: "Hervé Yviquel via Openmp-dev"
> >> > > <openmp-dev at lists.llvm.org>
> >> > > To: "Roel Jordans via Openmp-dev" <openmp-dev at lists.llvm.org>
> >> > > Sent: Wednesday, June 15, 2016 11:34:27 AM
> >> > > Subject: Re: [Openmp-dev] OpenMP 4 offloading status
> >> > >
> >> > > Hi all,
> >> > >
> >> > > I would like to know what is blocking libomptarget to be merge
> >> > > to the
> >> > > trunk? From the discussion about a common offloading with
> >> > > Google
> >> > > StreamExecutor, my understanding was that both should live
> >> > > separately
> >> > > in a first time... Any news from this side ?
> >> >
> >> > That's the plan. The news, as such, is that no one has okay'd
> >> > those
> >> > patches,
> >> > and we need more eyes on the code. If you'd like to help this
> >> > process,
> >> > please
> >> > help review the patches.
> >> >
> >> > Thanks again,
> >> > Hal
> >>
> >> I've reviewed the patches back in February but there are still
> >> some of my
> >> comments outstanding.
> >> I planned to give my ACK once they are discussed, I think they
> >> have been
> >> around for review long enough now so that everyone could have
> >> commented.
> >>
> >> Thanks,
> >> Jonas
> >>
> >> >
> >> > > For now, I'm still developing offloading to my own target in
> >> > > the
> >> > > github version of libomptarget on but I would like to update
> >> > > it to a
> >> > > more recent version of clang/llvm.
> >> > >
> >> > > Thanks,
> >> > > Hervé
> >> > >
> >> > > > Le 6 avr. 2016 à 16:20, Roel Jordans via Openmp-dev
> >> > > > <openmp-dev at lists.llvm.org> a écrit :
> >> > > >
> >> > > > Hi Carlo,
> >> > > >
> >> > > > Thanks for your response!  Good to see that things are under
> >> > > > review.
> >> > > >
> >> > > > Cheers,
> >> > > > Roel
> >> > > >
> >> > > > On 04/04/16 22:36, Carlo Bertolli wrote:
> >> > > >> Hi Roel
> >> > > >>
> >> > > >> I am not sure if someone already answered your question,
> >> > > >> but here
> >> > > >> is a description of the status to the best of my knowledge:
> >> > > >> offloading support for OpenMP includes implementation of
> >> > > >> target-related pragmas plus an offloading library,
> >> > > >> currently called
> >> > > >> libomptarget.
> >> > > >>
> >> > > >> The implementation of the pragmas happens in Clang and most
> >> > > >> of the
> >> > > >> constructs are implemented in trunk, notably except map
> >> > > >> clause,
> >> > > >> declare target, target update, and some clauses of teams.
> >> > > >> These
> >> > > >> remaining things are being worked on at this time, i.e. the
> >> > > >> patches
> >> > > >> are being discussed on phabricator.
> >> > > >>
> >> > > >> libomptarget is present as patches to the openmp library.
> >> > > >> You can
> >> > > >> find them here:
> >> > > >>
> >> > > >> http://reviews.llvm.org/D14031
> >> > > >> http://reviews.llvm.org/D14253
> >> > > >> http://reviews.llvm.org/D14254
> >> > > >>
> >> > > >> Finally, there are additional patches to the driver being
> >> > > >> discussed
> >> > > >> by the llvm community. These would enable compilation for
> >> > > >> different
> >> > > >> kinds of targets (same target region compiled for host and
> >> > > >> device
> >> > > >> selected by command line args), bundling of intermediate
> >> > > >> files,
> >> > > >> etc..
> >> > > >>
> >> > > >> Unfortunately, at this point in time putting all of these
> >> > > >> separate
> >> > > >> things together may not be easy.
> >> > > >>
> >> > > >>
> >> > > >> Cheers
> >> > > >>
> >> > > >> -- Carlo
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Inactive hide details for Roel Jordans via Openmp-dev
> >> > > >> ---04/02/2016
> >> > > >> 04:23:25 PM---Hi all, I've been looking into getting
> >> > > >> starteRoel
> >> > > >> Jordans via Openmp-dev ---04/02/2016 04:23:25 PM---Hi all,
> >> > > >> I've
> >> > > >> been looking into getting started with using OpenMP 4 to
> >> > > >> try out
> >> > > >>
> >> > > >> From: Roel Jordans via Openmp-dev
> >> > > >> <openmp-dev at lists.llvm.org>
> >> > > >> To: <openmp-dev at lists.llvm.org>
> >> > > >> Date: 04/02/2016 04:23 PM
> >> > > >> Subject: [Openmp-dev] OpenMP 4 offloading status Sent by:
> >> > > >> "Openmp-dev" <openmp-dev-bounces at lists.llvm.org>
> >> > > >>
> >> > > >> -------------------------------------------------------------------
> >> > > >> -----
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Hi all,
> >> > > >>
> >> > > >> I've been looking into getting started with using OpenMP 4
> >> > > >> to try
> >> > > >> out the offloading.  I've seen some nice presentations
> >> > > >> explaining
> >> > > >> the concepts and it sounds usable.  However, if I look at
> >> > > >> the
> >> > > >> openmp.llvm.org website, I see that this part is still
> >> > > >> "under
> >> > > >> development".
> >> > > >>
> >> > > >> Is there some list that I can look at that tells me the
> >> > > >> currently
> >> > > >> supported features or is this something I will just need to
> >> > > >> find
> >> > > >> out through trial and error?
> >> > > >>
> >> > > >> Cheers,
> >> > > >>  Roel
> >> > > >> _______________________________________________
> >> > > >> Openmp-dev mailing list
> >> > > >> Openmp-dev at lists.llvm.org
> >> > > >> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > > _______________________________________________
> >> > > > Openmp-dev mailing list
> >> > > > Openmp-dev at lists.llvm.org
> >> > > > http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> >> > >
> >> > > _______________________________________________
> >> > > Openmp-dev mailing list
> >> > > Openmp-dev at lists.llvm.org
> >> > > http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> >> > >
> >> >
> >> > --
> >> > Hal Finkel
> >> > Assistant Computational Scientist
> >> > Leadership Computing Facility
> >> > Argonne National Laboratory
> >> > _______________________________________________
> >> > Openmp-dev mailing list
> >> > Openmp-dev at lists.llvm.org
> >> > http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> >>
> >> _______________________________________________
> >> Openmp-dev mailing list
> >> Openmp-dev at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> >>
> >
> >
> > _______________________________________________
> > Openmp-dev mailing list
> > Openmp-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> >
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory


More information about the Openmp-dev mailing list