[Openmp-dev] Using Phabricator for OpenMP?

[John Mellor-Crummey]

I am new to committing to the LLVM OpenMP project.

The last time I committed using Phabricator, I added openmp-commits as a subscriber to the commit, as I believed was the custom.

With my most recent patch, I couldn’t put openmp-commits as a subscriber on the commit. I notice that for my previous posts to phabricator,  what was formerly a reference to "openmp-commits” in the subscribers is now marked as "Unknown Object (MLST)”. Something changed. What policies should I follow for commits to LLVM OpenMP?

--
John Mellor-Crummey         Professor
Dept of Computer Science    Rice University
email: johnmc at rice.edu      phone: 713-348-5179

> On Jul 9, 2015, at 9:47 AM, Jim Cownie <james.h.cownie at intel.com> wrote:
> 
> jcownie added a comment.
> 
> It looks generally fine, but I am nervous about putting the ompt state placeholders in OpenMP's namespace (by giving them thename prefix "omp_" ). Is there a reason not to name them "ompt_", which would move them into our namespace?
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D11062
> 
> 
> 
> 
> !DSPAM:8504,559e8993158741626675760!
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150709/219c8bf6/attachment.html>