<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I am new to committing to the LLVM OpenMP project.<div class=""><br class=""></div><div class="">The last time I committed using Phabricator, I added openmp-commits as a subscriber to the commit, as I believed was the custom.<br class=""><div class=""><br class=""></div><div class="">With my most recent patch, I couldn’t put openmp-commits as a subscriber on the commit. I notice that for my previous posts to phabricator, what was formerly a reference to "openmp-commits” in the subscribers is now marked as "<span style="background-color: rgb(255, 255, 255);" class=""><font color="#4b4d51" face="Segoe UI, Segoe UI Web Regular, Segoe UI Symbol, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="line-height: 17px;" class="">Unknown Object (MLST)”. Something changed. What policies should I follow for commits to LLVM OpenMP?</span></font></span><div class=""><br class=""></div><div class=""><div apple-content-edited="true" class="">
<span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px;"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; border-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-stroke-width: 0px;"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="font-size: 12px;" class=""><font face="Courier" class="">--<br class="">John Mellor-Crummey Professor<br class="">Dept of Computer Science Rice University<br class="">email: <a href="mailto:johnmc@rice.edu" class="">johnmc@rice.edu</a> phone: 713-348-5179</font><br class=""></div></div></span></div></span>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Jul 9, 2015, at 9:47 AM, Jim Cownie <<a href="mailto:james.h.cownie@intel.com" class="">james.h.cownie@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">jcownie added a comment.<br class=""><br class="">It looks generally fine, but I am nervous about putting the ompt state placeholders in OpenMP's namespace (by giving them thename prefix "omp_" ). Is there a reason not to name them "ompt_", which would move them into our namespace?<br class=""><br class=""><br class="">Repository:<br class=""> rL LLVM<br class=""><br class=""><a href="http://reviews.llvm.org/D11062" class="">http://reviews.llvm.org/D11062</a><br class=""><br class=""><br class=""><br class=""><br class="">!DSPAM:8504,559e8993158741626675760!<br class=""><br class=""><br class=""></div></blockquote></div><br class=""></div></div></div></body></html>