[Openmp-dev] Another four independent patches

Peyton, Jonathan L jonathan.l.peyton at intel.com
Mon Jan 26 08:34:58 PST 2015

It's been nearly a week, is it ok to commit these?

-- Johnny

From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-bounces at cs.uiuc.edu] On Behalf Of Peyton, Jonathan L
Sent: Tuesday, January 20, 2015 4:53 PM
To: openmp-dev at dcs-maillist2.engr.illinois.edu
Cc: Bliss, Brian E
Subject: [Openmp-dev] Another four independent patches

Descriptions of each patch (they are all independent):
1) teams_construct_fix.patch -- Fixed implementation of the teams construct in case it contains parallel regions with different number of threads and/or has pre or post parallel region.  Task teams are synchronized for each parallel and nesting levels are calculated correctly inside the barrier.
2) group_affinity.patch -- This replaces #if KMP_OS_WINDOWS && KMP_ARCH_X86_64 or any combination of those two options with the feature macro KMP_GROUP_AFFINITY.  This also adds some new Windows processor groups trace messages and enables a cpuid leaf 4 check for non-MIC x86 architectures.
3) remove_svn_revision_date.patch - Although this seems like a lot of changes it is just removing the $Revision and $Date svn variables from the top of all the source files.  Even though it touches numerous files, it should not interfere with any current development.
4) unused_vars_removed.patch - This patch removes some unused variables (__kmp_ht_*) and changes__kmp_ncores and __kmp_nThreadsPerCore to static globals within kmp_affinity.cpp.

To apply patches
$ patch -p0 < teams_construct_fix.patch
$ patch -p0 < group_affinity.patch
$ patch -p0 < unused_vars_removed.patch
$ patch -p0 < remove_svn_revision_date.patch

Since the remove_svn_revision_date.patch touches so many files at the very top, if you apply it before the others, you will inevitably get many Hunk #'s succeeded with offset messages for the subsequent patches.  So I would apply it last.

-- Johnny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150126/14fdcfb4/attachment.html>

More information about the Openmp-dev mailing list