[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in amdgpu plugin

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/OMPT/OmptCallback.cpp:67
+/// table maintained in the calling plugin library.
+void OmptCallbackInit() {
+  DP("OMPT: Entering OmptCallbackInit\n");
----------------
dhruvachak wrote:
> The comment says it is a constructor but I don't see the attribute. Are you calling it directly from elsewhere in a subsequent patch?
Yes, it will be called from `PluginInterface` (or `GenericPluginTy::init()` to be more precise) in patch 5/8 (https://reviews.llvm.org/D124652).
I'll remove the constructor comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070