[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in amdgpu plugin

Dhruva Chakrabarti via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Mar 21 22:25:48 PDT 2023


dhruvachak added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/OMPT/OmptCallback.cpp:67
+/// table maintained in the calling plugin library.
+void OmptCallbackInit() {
+  DP("OMPT: Entering OmptCallbackInit\n");
----------------
The comment says it is a constructor but I don't see the attribute. Are you calling it directly from elsewhere in a subsequent patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070



More information about the Openmp-commits mailing list