[Openmp-commits] [PATCH] D148808: [OpenMP][libomptarget][AMDGPU] Enable optional active HSA wait state

Fri Apr 21 05:47:12 PDT 2023

gregrodgers added a comment.

In D148808#4283842 <https://reviews.llvm.org/D148808#4283842>, @ye-luo wrote:

> Why separate KERNEL_BUSYWAIT and DATA_BUSYWAIT? I don't feel the need of two separate controls.
> What are the units? Documentation?

It is a matter of priorities.  If you are doing async copies, you may not want them to every busy-wait because you have more important things to do on the CPU.   However, in that same situation you may have high priority short kernels that you prefer to get the performance of busywait.

For long-term tuning, we may actually want more control over busy-wait timeouts.   For now, we just separate the timeouts on data transfers and kernel completions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148808/new/

https://reviews.llvm.org/D148808