[Openmp-commits] [PATCH] D148808: [OpenMP][libomptarget][AMDGPU] Enable optional active HSA wait state

Thu Apr 20 09:02:23 PDT 2023

kevinsala added inline comments.

================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1245

+  uint64_t KernelBusyWaitTics; // initialized from AMDGPUDeviceTy
+
----------------
ye-luo wrote:
> Should this be private?
Can we place this class data member just after the existing ones?

================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1575
+  uint64_t KernelBusyWaitTics;
+  uint64_t DataBusyWaitTics;
+
----------------
ye-luo wrote:
> Should they be private?
Are these fields really needed? We can access the envars directly (which have the values cached in a variable), right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148808/new/

https://reviews.llvm.org/D148808