[Openmp-commits] [PATCH] D60223: [OpenMP][libomptarget] Enable requires flags for target libraries.

Gheorghe-Teodor Bercea via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 21 08:51:33 PDT 2019


gtbercea added a comment.

In D60223#1510396 <https://reviews.llvm.org/D60223#1510396>, @Hahnfeld wrote:

> In D60223#1507576 <https://reviews.llvm.org/D60223#1507576>, @Hahnfeld wrote:
>
> > In this patch `__tgt_rtl_init_requires` does nothing. Do we really want to add the prototype now? If yes, are we sure that we won't need to pass more information in the future? Once we add it, the runtime library must maintain compatibility.
>
>
> Ping. At the moment this patch just stores the `RequiresFlags` in the plugins and never uses it.


If you check the declare target link patch it will be used there. I can move this part of the code to that patch.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60223/new/

https://reviews.llvm.org/D60223





More information about the Openmp-commits mailing list