[Openmp-commits] [PATCH] D60223: [OpenMP][libomptarget] Enable requires flags for target libraries.

Tue May 21 08:39:53 PDT 2019

Hahnfeld added a comment.

In D60223#1507576 <https://reviews.llvm.org/D60223#1507576>, @Hahnfeld wrote:

> In this patch `__tgt_rtl_init_requires` does nothing. Do we really want to add the prototype now? If yes, are we sure that we won't need to pass more information in the future? Once we add it, the runtime library must maintain compatibility.

Ping. At the moment this patch just stores the `RequiresFlags` in the plugins and never uses it.

================
Comment at: libomptarget/test/offloading/requires.c:25-26
+
+void run_reg_requires()
+{
+  // Before the target region is registered, the requires registers the status
----------------
Could you please run `clang-format` on this file?

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60223/new/

https://reviews.llvm.org/D60223