[Openmp-commits] [PATCH] D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs
Daniel Berlin via Openmp-commits
openmp-commits at lists.llvm.org
Thu Oct 13 07:38:53 PDT 2016
On Thu, Oct 13, 2016 at 2:26 AM, Hal Finkel <hfinkel at anl.gov> wrote:
> hfinkel added a comment.
> In https://reviews.llvm.org/D13072#256043, @dberlin wrote:
> > In https://reviews.llvm.org/D13072#252598, @jcownie wrote:
> > > It generally looks fine to me.
> > >
> > > My one concern is over the licence in the header file. It looks like
> a BSD-ish licence, but it's not the same as either of the licences which
> apply to the rest of the code ( http://llvm.org/svn/llvm-
> project/openmp/trunk/LICENSE.txt ). (Of course, IANAL).
> > Urf. Speaking as a lawyer, in practice, this doesn't matter.
> > However, we should fix all of these, not just the Google one.
> > The BSD license in that project should not be the license we use. We
> have generally not given credit to specific groups *in the license*, as
> that LICENSE does, but instead elsewhere. The license should be the same
> license we use for runtime libraries elsewhere (which is not even BSD, but
> > I'll start a thread about this.
> @dberlin , how do we move forward here? Having the OpenMP runtime library
> work well with TSan is important.
These licenses really need to be changed out for the llvm license (or the
proposed license + exception).
Right now, any openMP using program has to be reproducing this entire
license text, plus nobody has ever evaluated that the ARM license in there
is really open source/compatible with other licenses.
I believe when I mentioned this issue to various folks, the answer was
basically "we didn't realize it had gotten accepted with this set of
So my strong suggestion is that we just fix this.
We may want to wait until the llvm license issues are finalized if we can,
but if we can't, the clear path forward is to license it at least
*consistently* and without N different copyright notices.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Openmp-commits