[Mlir-commits] [mlir] [mlir] Revert to old fold logic in IR::Dialect::addTypes() (PR #79582)

[Andrei Golubev]

andrey-golubev wrote:

> > btw, given this problem is likely to stay with us for a while, should I also change addAttributes() / addInterfaces()? Chances are, someone would hit it eventually ...
> 
> Personally I think it'd make sense to change it for `addAttributes` as well as it is not unlikely to reach similar sizes as types and is also called by `TableGen` generated code. I think `addInterfaces` is only ever called by users and is rather unlikely to hit the 256 types limit but I might be misremembering.

Quite. My gut feeling tells the same. Guessing if addAttributes is called TableGen so does the addInterfaces? But given that interfaces, well, abstract away common functionality, the amount of them should be a magnitude smaller.


https://github.com/llvm/llvm-project/pull/79582