[llvm-dev] RFC for f18+runtimes in LLVM

Adrian Prantl via llvm-dev llvm-dev at lists.llvm.org
Fri Mar 1 14:45:27 PST 2019



> On Mar 1, 2019, at 2:36 PM, Adrian Prantl via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> 
> 
> 
>> On Mar 1, 2019, at 11:45 AM, David Greene via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> 
>> There are Differentials posted for Fortran debug handling in LLVM and
>> the last update on them was Nov. 28.  As far as I can tell the status on
>> them is:
>> 
>> https://reviews.llvm.org/D54327 - Looks ready to land, awaiting approval
>> from someone.  Who is the someone?
> 
>> https://reviews.llvm.org/D54043 - Paul Robinson did some groundwork
>> to aid the effort.  No updates since.
>> 
>> https://reviews.llvm.org/D54114 - No updates since Nov. 6.  Some
>> questions awaiting response.
> 
> Because of the large volume of patches that need to be reviewed it often happens that a review can get stuck. The accepted best practice is to ping the review thread, e.g. once per week to force it to the top of the review's queue and specifically call out what questions need answering, etc...

Looks like I replied to quickly... After reading through these reviews all of them are (as was actually pointed out earlier in this thread) stuck on the patch authors answering questions and not waiting on reviewers.

-- adrian


More information about the llvm-dev mailing list