[llvm-dev] [CommandLine] Missing clEnumValEnd for cl::values in tutorial page
Martin J. O'Riordan via llvm-dev
llvm-dev at lists.llvm.org
Wed Jun 7 02:13:49 PDT 2017
There used to be a ‘clEnumValEnd’ in LLVM v3.9, but it was removed when I updated to v4.0. Is this being re-introduced in v5.0?
From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Bekket McClane via llvm-dev
Sent: 6 June 2017 15:07
To: 陳韋任 <chenwj.cs97g at g2.nctu.edu.tw>
Cc: LLVM Mailing List <llvm-dev at lists.llvm.org>
Subject: Re: [llvm-dev] [CommandLine] Missing clEnumValEnd for cl::values in tutorial page
Thanks for you reminding, It turns out that the function prototype of cl::values had just changed between 4.x and the current trunk(5.x), and the current version is not null terminated anymore.
(The online reference page http://llvm.org/docs/doxygen/html/CommandLine_8h.html is based on 4.x)
In another word, version of the tutorial page seems to be later than that of the reference page
I would close the issue later
陳韋任 <chenwj.cs97g at g2.nctu.edu.tw <mailto:chenwj.cs97g at g2.nctu.edu.tw> > 於 2017年6月6日 下午9:15 寫道：
I don't see any use case in the codebase adding clEnumValEnd at the end of list (for example, ), I also don't see there is
clEnumValEnd. Do I miss something here?
2017-06-06 9:53 GMT+08:00 Bekket McClane via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >:
Can anyone help reviewing the code?
I think this revision is pretty important regarding that the command line library is also used in many non-LLVM projects.
It’s nice to provide a correct guideline to whom use the library for the first time.
Bekket McClane <bekket.mcclane at gmail.com <mailto:bekket.mcclane at gmail.com> > 於 2017年6月3日 下午9:00 寫道：
The argument list for cl::values in command line library should be end with null or clEnumValEnd. But the tutorial page(http://llvm.org/docs/CommandLine.html) doesn’t follow the rule, which would cause program crash during runtime.
I’d send a code review: https://reviews.llvm.org/D33861
Please cc other folks related to this part.
LLVM Developers mailing list
llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
Wei-Ren Chen (陳韋任)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev