[llvm-dev] [RFC] Require PRs for XFAILing tests

Robinson, Paul via llvm-dev llvm-dev at lists.llvm.org
Mon Oct 3 10:55:35 PDT 2016



> -----Original Message-----
> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of
> Krzysztof Parzyszek via llvm-dev
> Sent: Monday, October 03, 2016 10:40 AM
> To: llvm-dev at lists.llvm.org
> Subject: Re: [llvm-dev] [RFC] Require PRs for XFAILing tests
> 
> On 10/3/2016 12:21 PM, Robinson, Paul via llvm-dev wrote:
> > As David Blaikie mentioned, our bug hygiene is not really that good.
> 
> Adding a process to create more PRs is not going to change that.

Of course not.  The point of my remark is that linking an XFAIL test
to a generic content-free PR is no better than having no link at all,
*because* our hygiene is not good.

> Until
> we have a plan to address that, forcing more bug reports is not really
> going to accomplish much.

If the XFAIL-linked PRs are content-free, that is worse than useless.
The point is to have those PRs say something useful about the specific
XFAIL case, which is a vast improvement over what we have today (i.e.,
almost nothing).

According to numbers thrown around on this thread, the net increase
in PRs would be around 1%.
--paulr

> 
> -Krzysztof
> 
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev


More information about the llvm-dev mailing list