[llvm-dev] Is there a reason why MCAsmStreamer class doesn't have its own .h file?

Craig Topper via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 21 17:03:37 PST 2016


I dont' know why its final. That routine is just a method to force the
current write pointer to a specific alignment. Shouldn't you be changing
the callers to give you the alignment you want or don't want.

On Thu, Jan 21, 2016 at 4:29 PM, Rail Shafigulin <rail at esenciatech.com>
wrote:

>
>
> On Thu, Jan 21, 2016 at 4:04 PM, Craig Topper <craig.topper at gmail.com>
> wrote:
>
>> Isn't it also marked 'final' so it can't be inherited from anyway? What's
>> your need to inherit from it?
>> --
>> ~Craig
>>
>
> Oops, missed the final part. I need to change the alignment. For my target
> it is sort of independent of the data layout. I was going to overwrite
> void MCAsmStreamer::EmitValueToAlignment(unsigned ByteAlignment, int64_t
> Value, unsigned ValueSize, unsigned MaxBytesToEmit).
>
> What is the reason it was made final? Why not to separate this class into
> its own module?
> --
> Rail Shafigulin
> Software Engineer
> Esencia Technologies
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160121/38a61ec4/attachment.html>


More information about the llvm-dev mailing list