[llvm-dev] RFC: Move the test-suite LLVM project to GitHub?
Pete Cooper via llvm-dev
llvm-dev at lists.llvm.org
Wed Feb 24 22:21:44 PST 2016
Sent from my iPhone
> On Feb 24, 2016, at 6:25 PM, Chandler Carruth via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> I just want to clarify in case anyone is confused: I am in no way suggesting that we would use pull requests, issues, or anything else as part of the workflow for the test suite. I'm fine if folks want to talk about that later, but I really view it as a separate discussion. I'm much more interested in just leveraging the managed *hosting* of the repository
This is actually the discussion I really want to happen before we move any code.
Firstly, I use git and git-svn every day so I would much prefer the test suite in git. So I'm still very much a +1 for that.
However, when I first started using git for llvm I had to adjust from the svn commands to the git ones and using pull/rebase instead of things like merge.
Learning those things in my own repo is fine, and several times I screwed up and blew away the repo to start again from a good state. But the point is that I made those mistakes on my own machine. I'm scared of anyone else making those mistakes to the llvm test suite. That is the big advantage of the pull request model and I think that's something we should consider for any git based llvm code, including the tests.
I'm also open to alternatives, but as I said, we need some way, even if it's pre-commit hooks, to make sure that anyone other that admins are behaving (not pushing too many commits at a time, no merges, etc)
More information about the llvm-dev