[llvm-dev] RFC: speedups with instruction side-data (ADCE, perhaps others?)

escha via llvm-dev llvm-dev at lists.llvm.org
Mon Sep 14 15:25:31 PDT 2015


> On Sep 14, 2015, at 2:58 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> 
> 
>> On Sep 14, 2015, at 2:49 PM, Matt Arsenault via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> 
>> On 09/14/2015 02:47 PM, escha via llvm-dev wrote:
>>> I would assume that it’s just considered to be garbage. I feel like any sort of per-pass side data like this should come with absolute minimal contracts, to avoid introducing any more inter-pass complexity.
>> I would think this would need to be a verifier error if it were ever non-0
> +1
> 
> Otherwise every pass which ever needs this bit would have to first zero it out just to be safe, adding an extra walk over the whole functions.

My ADCE patch doesn’t need an extra walk over the function; it just marks them as Alive or Not Alive during the first walk.

—escha


More information about the llvm-dev mailing list