[LLVMdev] Final added to parser<bool>
reed.kotler at imgtec.com
Thu Mar 19 09:37:11 PDT 2015
On 03/19/2015 09:27 AM, Simon Atanasyan wrote:
> On Thu, Mar 19, 2015 at 7:18 PM, Reed Kotler <reed.kotler at imgtec.com> wrote:
>> I still don't see any justification to making a change in a public interface
>> that is used by other non LLVM projects
>> to fix some issue with clang warnings. People should be able to derive from
>> those classes. I can't understand
>> your reasoning as to why these classes must be final.
> From my point of view this class is a good candidate to be final. I
> cannot realize a real test case when somebody needs to extend parsing
> of boolean command line flags. If MCLinker had been part of the LLVM
> project the FalseParser design would not have passed review.
Isn't this a problem without how these classes were designed as opposed to
a problem with someone wanting to derive from ?
>> I was kind of surprised that there are no mclinker build bots that would
>> have picked this up right away.
> MCLinker does not use LLVM ToT. It migrates to the fresh version of
> LLVM from time to time.
Seems like we need to fix the mclinker wiki so that people know which
version to use.
The mclinker instructions just have one checking out from tip of tree.
> Simon Atanasyan
More information about the llvm-dev