[LLVMdev] lld coding style
clattner at apple.com
Thu Oct 9 18:01:44 PDT 2014
On Oct 9, 2014, at 2:58 PM, Nick Kledzik <kledzik at apple.com> wrote:
>> My two cents: LLVM's conventions around method names and local variable names are widely ignored. For example, the IRBuilder uses leading capitals for methods. Clang CodeGen does as well. Clang CodeGen also uses lots of local variables with leading lower-case letters, which is against the variable naming guidelines.
>> I think the takeaway from that is that lots of people don't actually understand or agree with the LLVM naming standards in this area. I don't think we should do a mass rename in LLD if we aren't willing to do a mass rename across Clang internals, and so far no one has indicated a desire to do that.
> Yes. The top of the LLVM coding conventions, the “golden rule” is don’t do mass renames. So, I’m surprised at the desire for mass renamings.
I think we should separate the discussions of “what the right thing is” vs “what to do about it”. If we come to agreement about what the right thing is, we can figure out if incremental or big-bang is the right way to go.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev