[LLVMdev] lld coding style

Zachary Turner zturner at google.com
Tue Oct 7 08:05:14 PDT 2014

Not sure I understand.  How would reformatting the code change the
semantics?  Why would something that used to work no logner work with a
re-written history?

On Tue, Oct 7, 2014 at 12:47 AM, Renato Golin <renato.golin at linaro.org>

> On 7 October 2014 08:28, Zachary Turner <zturner at google.com> wrote:
> > 2) For each formatted commit F, find the corresponding unformatted
> commit U.
> > Determine the set of all files modified between U and U+1, and reformat
> all
> > of these files, placing them in the working copy of the new repository.
> > Commit this patch to the new repository using the commit information from
> > U+1.
> You mean, for *every* commit in lld until now? That's not just
> re-writing the history of the files, but of the project itself! There
> is no guarantee that what worked in the past works with the history
> re-written, what was tested then won't be tested now, people that had
> patches against previous releases won't apply at all.
> Even if lld had no connections whatsoever to anything else in the
> external world, I'd still be against it.
> > Note that variable names are outside the scope of this.
> Unfortunately, that's one of the biggest changes proposed...
> cheers,
> --renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141007/ee7b56d0/attachment.html>

More information about the llvm-dev mailing list