[LLVMdev] Handling of unsafe functions
clattner at apple.com
Fri Sep 21 09:39:51 PDT 2012
On Sep 20, 2012, at 3:08 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> > I agree with Sean that we should move the code using C strings to LLVM
> > safe data types.
> I agree.
> > And one more thing: it is interesting that the "unsafe"
> > APFloat::convertToHexString (from your patch) is not used anywhere.
> Zap it! Oh wait, is it used by Clang or something else?
> Clang doesn't use it, but LLDB does, with an arbitrary-seeming 256-character buffer. Perhaps we should change it to take an llvm::SmallVectorImpl<char>, rather than relying on a character buffer "which must be of sufficient size".
Makes sense to me,
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev