<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Sep 20, 2012, at 3:08 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><blockquote type="cite"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div class="im">> I agree with Sean that we should move the code using C strings to LLVM<br>
> safe data types.<br>
<br>
</div>I agree.<br>
<div class="im"><br>
><br>
> And one more thing: it is interesting that the "unsafe"<br>
> APFloat::convertToHexString (from your patch) is not used anywhere.<br>
<br>
</div>Zap it! Oh wait, is it used by Clang or something else?</blockquote><div><br></div><div>Clang doesn't use it, but LLDB does, with an arbitrary-seeming 256-character buffer. Perhaps we should change it to take an llvm::SmallVectorImpl<char>, rather than relying on a character buffer "which must be of sufficient size".</div>
</div>
</blockquote></div><br><div>Makes sense to me,</div><div><br></div><div>-Chris</div></body></html>