[LLVMdev] R_ARM_ABS32 disassembly with integrated-as

[Renato Golin]

On 17 October 2012 15:05, Greg Fitzgerald <garious at gmail.com> wrote:
> +  virtual void EmitMappingSymbol(bool IsData);

I'd use an enum, or have multiple internal implementations...

EmitDataMappingSymbol -> { nop on base class, on ARM, prints "$d" }
EmitCodeMappingSymbol -> { nop on base class, calling either
EmitThumbMappingSymbol or EmitARMMappingSymbol (private) on ARM }


> +void MCELFStreamer::EmitMappingSymbol(bool IsData) {
> +  // FIXME: The following is specific to the ARM.  This should be moved
> +  //        to ARMAsmBackend.

Maybe MCARMELFStreamer (or whatever sounds nicer than that). ARMAsm is
a big bag of code and nowadays, most of it is format agnostic, I think
(asm, elf).


-- 
cheers,
--renato

http://systemcall.org/